Skip to content

fix: emit console.log on fuzz test last run at verbosity >= 2 #12478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 28, 2025
Merged

fix: emit console.log on fuzz test last run at verbosity >= 2 #12478

merged 8 commits into from
Nov 28, 2025
+26 −6

Conversation

@avorylli
Copy link
Contributor

@avorylli avorylli commented Nov 6, 2025

Fixes #11039

Always collect logs from the last fuzz run and include them in results when show_logs: false, enabling display at verbosity >= 2. Preserves existing behavior when show_logs: true.

onbjerg
onbjerg requested changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally the logs for the last run are present in logs. currently they are not, which is what the bug is about. is there any reason we can't do that you came across?

@avorylli
Copy link
Contributor Author

avorylli commented Nov 13, 2025

My bad, its actually better to do as you described. Last run logs are now always stored in test_data.logs.

Removed last_run_logs - when show_logs is false, we replace logs with each run's logs, keeping only the last one.

@avorylli avorylli requested a review from onbjerg November 13, 2025 20:58
@avorylli
Copy link
Contributor Author

avorylli commented Nov 17, 2025

@onbjerg pinging

@onbjerg onbjerg added this pull request to the merge queue Nov 28, 2025
Merged via the queue into foundry-rs:master with commit fda2b7e Nov 28, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 28, 2025
@grandizzy
Copy link
Collaborator

grandizzy commented Nov 30, 2025

I guess that's fine but it pollutes the output when bound is used https://github.com/foundry-rs/forge-std/blob/755e679abefaf6ca9a08b5b9b90a52fb9b4ee188/src/StdUtils.sol#L60 e.g. https://github.com/foundry-rs/foundry/actions/runs/19795110493/job/56714245384?pr=12698#step:14:3515
will do a forge-std PR to remove console.log from bound as tests output is really hard to follow now

@grandizzy grandizzy mentioned this pull request Nov 30, 2025
Merged
grandizzy added a commit to foundry-rs/forge-std that referenced this pull request Nov 30, 2025
@grandizzy
fix: config test to use reth, remove log from bound (#763)
b69e66b 
- use reth node in config tests instead eth.llamarpc
- remove log from bound fn to address
foundry-rs/foundry#12478 (comment)
Projects should `console.log` bounded value in tests themselves if
needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: console.log values are not emitted on fuzz tests's last run at any verbosity level

4 participants

@avorylli @grandizzy @onbjerg @DaniPopes